snapshot_toolchain.gni - Issue 1952973004: Use default toolchain for v8 snapshot when target_os = chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot_toolchain.gni

Issue 1952973004: Use default toolchain for v8 snapshot when target_os = chromeos (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot_toolchain.gni

diff --git a/snapshot_toolchain.gni b/snapshot_toolchain.gni

index 4932110489dd1a7fe65a6124aa655192661d3bd6..379e63a6351bbe2d7d577d741673349910925502 100644

--- a/snapshot_toolchain.gni

+++ b/snapshot_toolchain.gni

@@ -31,7 +31,7 @@

# TODO(GYP): For now we only support 32-bit little-endian target builds from an

# x64 Linux host. Eventually we need to support all of the host/target

# configurations v8 runs on.

-if (host_cpu == "x64" && host_os == "linux") {

+if (host_cpu == "x64" && host_os == "linux" && target_os != "chromeos") {

if (target_cpu == "arm" || target_cpu == "mipsel" || target_cpu == "x86") {

snapshot_toolchain = "//build/toolchain/linux:clang_x86"

} else if (target_cpu == "x64" || target_cpu == "arm64" || target_cpu == "mips64el") {

« no previous file with comments | « no previous file | no next file » | no next file with comments »