Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1952973002: Remove UserUnits from CSSPrimitiveValue::unitTable (Closed)

Created:
4 years, 7 months ago by Timothy Loh
Modified:
4 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove UserUnits from CSSPrimitiveValue::unitTable We never call CSSPrimitiveValue::fromName with an empty string, so there is no reason to have UserUnits in the unit table. Committed: https://crrev.com/11b4ce0b629a874c17b73fbe97504ea72fd2bf68 Cr-Commit-Position: refs/heads/master@{#391769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Timothy Loh
4 years, 7 months ago (2016-05-05 05:09:43 UTC) #2
alancutter (OOO until 2018)
rs lgtm.
4 years, 7 months ago (2016-05-05 05:45:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952973002/1
4 years, 7 months ago (2016-05-05 06:04:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 06:16:05 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 06:17:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11b4ce0b629a874c17b73fbe97504ea72fd2bf68
Cr-Commit-Position: refs/heads/master@{#391769}

Powered by Google App Engine
This is Rietveld 408576698