Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1952953004: Remove NEON runtime detection support. (Closed)

Created:
4 years, 7 months ago by mtklein_C
Modified:
4 years, 7 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove NEON runtime detection support. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952953004 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/809ccf37ec836d0df64afd0b13023fd968d505a4

Patch Set 1 #

Patch Set 2 : (x) #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -159 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M gyp/common_variables.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/libjpeg-turbo.gyp View 4 chunks +10 lines, -10 lines 0 comments Download
M gyp/opts.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M gyp/opts.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M platform_tools/android/bin/android_setup.sh View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcState_matrixProcs.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkBlitter_RGB16.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkOpts.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M src/core/SkUtilsArm.h View 1 1 chunk +4 lines, -67 lines 2 comments Download
D src/opts/SkOpts_neon.cpp View 1 chunk +0 lines, -54 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952953004/1
4 years, 7 months ago (2016-05-05 17:30:45 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/8343) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
4 years, 7 months ago (2016-05-05 17:31:55 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952953004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952953004/20001
4 years, 7 months ago (2016-05-05 17:34:15 UTC) #7
mtklein_C
4 years, 7 months ago (2016-05-05 17:38:39 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 17:53:29 UTC) #11
djsollen
lgtm https://codereview.chromium.org/1952953004/diff/20001/src/core/SkUtilsArm.h File src/core/SkUtilsArm.h (right): https://codereview.chromium.org/1952953004/diff/20001/src/core/SkUtilsArm.h#newcode16 src/core/SkUtilsArm.h:16: #define SK_ARM_NEON_WRAP(x) (x) can we remove this wrapper ...
4 years, 7 months ago (2016-05-05 17:55:08 UTC) #12
mtklein_C
https://codereview.chromium.org/1952953004/diff/20001/src/core/SkUtilsArm.h File src/core/SkUtilsArm.h (right): https://codereview.chromium.org/1952953004/diff/20001/src/core/SkUtilsArm.h#newcode16 src/core/SkUtilsArm.h:16: #define SK_ARM_NEON_WRAP(x) (x) On 2016/05/05 at 17:55:08, djsollen wrote: ...
4 years, 7 months ago (2016-05-05 17:57:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952953004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952953004/20001
4 years, 7 months ago (2016-05-05 17:57:45 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 17:58:42 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/809ccf37ec836d0df64afd0b13023fd968d505a4

Powered by Google App Engine
This is Rietveld 408576698