testing/test_support.cpp - Issue 1952923002: Combine corpus runner into test_runner.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/test_support.cpp

Issue 1952923002: Combine corpus runner into test_runner.py (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/test_support.cpp

diff --git a/testing/test_support.cpp b/testing/test_support.cpp

index c50edeba2da888e68b971dbca25cb8a5d2d59a88..701ebfa777ddeb9eae55fec92b7a5864acbff42e 100644

--- a/testing/test_support.cpp

+++ b/testing/test_support.cpp

@@ -77,10 +77,9 @@ void InitializeV8Common(v8::Platform** platform) {

std::unique_ptr<char, pdfium::FreeDeleter> GetFileContents(const char* filename,

size_t* retlen) {

FILE* file = fopen(filename, "rb");

- if (!file) {

- fprintf(stderr, "Failed to open: %s\n", filename);

+ if (!file)

return nullptr;

- }

(void)fseek(file, 0, SEEK_END);

size_t file_length = ftell(file);

if (!file_length) {