Combine corpus runner into test_runner.py

Combine corpus runner into test_runner.py

This CL combines the corpus runner into the test_runner.py. This also
enables the javascript and pixel runners to do a multi test runner.

Committed: https://pdfium.googlesource.com/pdfium/+/849284d54b5caeaf662d5890dbab5a6384598613

[dsinclair, 2016-05-05 15:30:14]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-05-05 15:30:17]

PTAL.

[Tom Sepez, 2016-05-05 16:39:08]

https://codereview.chromium.org/1952923002/diff/40001/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/1952923002/diff/40001/samples/pdfium_test.cc#...
samples/pdfium_test.cc:820: std::string test_dir = "pdfium/testing/";
Feels like this shouldn't have any knowledge of the directory tree, instead
maybe give it a command line argument about where to write its result files (if
not in same directory as input files), then pass that in from the .py scripts.

[dsinclair, 2016-05-05 16:45:08]

https://codereview.chromium.org/1952923002/diff/40001/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/1952923002/diff/40001/samples/pdfium_test.cc#...
samples/pdfium_test.cc:820: std::string test_dir = "pdfium/testing/";
On 2016/05/05 16:39:08, Tom Sepez wrote:
> Feels like this shouldn't have any knowledge of the directory tree, instead
> maybe give it a command line argument about where to write its result files
(if
> not in same directory as input files), then pass that in from the .py scripts.


This is just for the fprintf below. I was trying to change it so that instead of
a 200 character long path we get a 50 character path. Makes reading the output a
lot simpler. But, I only really want to do that when we're running our tests,
not for other files. So, it isn't the output dir, it's the input dir that I care
about.

[Tom Sepez, 2016-05-05 17:29:27]

> This is just for the fprintf below. I was trying to change it so that instead
of
> a 200 character long path we get a 50 character path. Makes reading the output
a
> lot simpler. But, I only really want to do that when we're running our tests,
> not for other files. So, it isn't the output dir, it's the input dir that I
care
> about.

Nah, if I've got a few independent repo's checked out, and I'm looking at the
results of something that failed a few days ago, I really need to know the whole
path.  Throwing away that information seems counter-productive.

[dsinclair, 2016-05-05 17:36:26]

On 2016/05/05 17:29:27, Tom Sepez wrote:
> > This is just for the fprintf below. I was trying to change it so that
instead
> of
> > a 200 character long path we get a 50 character path. Makes reading the
output
> a
> > lot simpler. But, I only really want to do that when we're running our
tests,
> > not for other files. So, it isn't the output dir, it's the input dir that I
> care
> > about.
> 
> Nah, if I've got a few independent repo's checked out, and I'm looking at the
> results of something that failed a few days ago, I really need to know the
whole
> path.  Throwing away that information seems counter-productive.


Removed. PTAL.

[Tom Sepez, 2016-05-05 17:49:18]

lgtm.  Not sure how OOO Lei is, would like his thoughts.

[dsinclair, 2016-05-16 14:18:28]

thestig@ PTAL.

[Lei Zhang, 2016-05-17 01:32:42]

lgtm

[dsinclair, 2016-05-17 12:58:02]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-05-17 12:58:02]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1952923002/#ps80001
(title: "Rebase to master")

[commit-bot: I haz the power, 2016-05-17 12:58:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952923002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952923002/80001

[commit-bot: I haz the power, 2016-05-17 13:13:40]

Description was changed from

==========
Combine corpus runner into test_runner.py

This CL combines the corpus runner into the test_runner.py. This also
enables the javascript and pixel runners to do a multi test runner.
==========

to

==========
Combine corpus runner into test_runner.py

This CL combines the corpus runner into the test_runner.py. This also
enables the javascript and pixel runners to do a multi test runner.

Committed:
https://pdfium.googlesource.com/pdfium/+/849284d54b5caeaf662d5890dbab5a638459...
==========

[commit-bot: I haz the power, 2016-05-17 13:13:41]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/849284d54b5caeaf662d5890dbab5a638459...