Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Issue 1952903002: - Fix loading of dart:html. - Remove debug print in VM service. (Closed)

Created:
4 years, 7 months ago by Ivan Posva
Modified:
4 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Fix loading of dart:html. - Remove debug print in VM service. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/964f95a0207760f0efb8c1e75e7167c28d47f21b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -33 lines) Patch
M runtime/bin/builtin.h View 2 chunks +3 lines, -16 lines 0 comments Download
M runtime/bin/builtin.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M runtime/bin/builtin_nolib.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M runtime/vm/object_service.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Ivan Posva
4 years, 7 months ago (2016-05-05 00:37:29 UTC) #2
siva
lgtm
4 years, 7 months ago (2016-05-05 00:41:45 UTC) #4
Ivan Posva
4 years, 7 months ago (2016-05-05 00:44:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
964f95a0207760f0efb8c1e75e7167c28d47f21b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698