Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h

Issue 1952893003: Implement custom element construction and some 'define' checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use DCHECK, revert RuntimeEnabledFeatures.in. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h
index 2d78fdf14ae2c61e98158f65c52d807b868eeef2..349dd134587cc0aa82babe1223f8367c2d43f369 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h
@@ -7,32 +7,59 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "core/CoreExport.h"
+#include "platform/heap/Handle.h"
+#include "v8.h"
+#include "wtf/HashSet.h"
+#include "wtf/text/AtomicString.h"
+#include "wtf/text/AtomicStringHash.h"
namespace blink {
+class CustomElementDefinition;
class ElementRegistrationOptions;
class ExceptionState;
class ScriptState;
class ScriptValue;
class CORE_EXPORT CustomElementsRegistry final
- : public GarbageCollected<CustomElementsRegistry>
+ : public GarbageCollectedFinalized<CustomElementsRegistry>
, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
- static CustomElementsRegistry* create()
- {
- return new CustomElementsRegistry();
- }
+ static CustomElementsRegistry* create(ScriptState*);
- void define(ScriptState*, const AtomicString& name,
- const ScriptValue& constructor, const ElementRegistrationOptions&,
+ void define(
+ ScriptState*,
+ const AtomicString& name,
+ const ScriptValue& constructor,
+ const ElementRegistrationOptions&,
ExceptionState&);
+ CustomElementDefinition* definitionForConstructor(
+ v8::Handle<v8::Context>,
+ v8::Handle<v8::Value>);
+
+ // TODO(dominicc): Remove this when V0CustomElements are removed.
+ bool nameIsDefined(const AtomicString&) const;
+
+ void setWrapperReferences(
+ v8::Isolate*,
+ const v8::Persistent<v8::Object>& wrapper) const;
+
DECLARE_TRACE();
private:
- CustomElementsRegistry();
+ CustomElementsRegistry(v8::Isolate*);
+
+ // This maps Custom Element constructors to an index in the list
+ // of defined elements. This handle is not weak because it does
+ // not keep user-accessible objects alive: the keys are already
+ // weak (it is a weak map) and the values are numbers (not
+ // NumberObjects) which don't refer to anything else.
+ v8::Persistent<v8::NativeWeakMap> m_constructorIdMap;
+
+ HeapVector<Member<CustomElementDefinition>> m_definitions;
+ HashSet<AtomicString> m_names;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698