Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h

Issue 1952893003: Implement custom element construction and some 'define' checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implement feedback. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h
diff --git a/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h b/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h
index f2b6cf6aec092c4b51a7eb637baa045d6942e1df..a030766b98a56a24242281a7bdd06a889f7366f1 100644
--- a/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h
+++ b/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h
@@ -42,8 +42,9 @@
namespace blink {
-class V0CustomElementConstructorBuilder;
+class CustomElementsRegistry;
class ExceptionState;
+class V0CustomElementConstructorBuilder;
class V0CustomElementRegistry final {
WTF_MAKE_NONCOPYABLE(V0CustomElementRegistry);
@@ -60,10 +61,16 @@ protected:
V0CustomElementDefinition* registerElement(Document*, V0CustomElementConstructorBuilder*, const AtomicString& name, V0CustomElement::NameSet validNames, ExceptionState&);
V0CustomElementDefinition* find(const V0CustomElementDescriptor&) const;
+ bool nameIsDefined(const AtomicString& name) const;
+ void setV1(const CustomElementsRegistry*);
+
private:
+ bool v1NameIsDefined(const AtomicString& name) const;
+
typedef HeapHashMap<V0CustomElementDescriptor, Member<V0CustomElementDefinition>> DefinitionMap;
DefinitionMap m_definitions;
HashSet<AtomicString> m_registeredTypeNames;
+ Member<const CustomElementsRegistry> m_v1;
bool m_documentWasDetached;
};

Powered by Google App Engine
This is Rietveld 408576698