third_party/WebKit/Source/core/dom/Document.cpp - Issue 1952893003: Implement custom element construction and some 'define' checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1952893003: Implement custom element construction and some 'define' checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Do not expose CustomElementsRegistry to isolated worlds. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index f05f277465d432d8b9a6bc5a7f928ba1b961aeee..9a965e0430db4c7c42e2069d84ee580b47be67ac 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -742,7 +742,7 @@ ScriptValue Document::registerElement(ScriptState* scriptState, const AtomicStri

}

V0CustomElementConstructorBuilder constructorBuilder(scriptState, options);

- registrationContext()->registerElement(this, &constructorBuilder, name, validNames, exceptionState);

+ registrationContext()->registerElement(scriptState, this, &constructorBuilder, name, validNames, exceptionState);

return constructorBuilder.bindingsReturnValue();

}