 Chromium Code Reviews
 Chromium Code Reviews Issue 1952893003:
  Implement custom element construction and some 'define' checks  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1952893003:
  Implement custom element construction and some 'define' checks  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW | 
|---|---|
| (Empty) | |
| 1 function create_window() { | |
| 2 let p = new Promise((resolve) => { | |
| 3 let f = document.createElement('iframe'); | |
| 4 f.srcdoc = ''; | |
| 5 f.onload = (event) => { | |
| 6 let w = f.contentWindow; | |
| 7 w.tearDown = () => f.remove(); | |
| 8 resolve(w); | |
| 9 }; | |
| 10 document.body.appendChild(f); | |
| 11 }); | |
| 12 return p; | |
| 13 } | |
| 14 | |
| 15 function async_test_with_window(f, name) { | |
| 
domenic
2016/05/05 19:15:28
In general async_test is worse than promise_test;
 | |
| 16 async_test((t) => { | |
| 17 create_window().then((w) => { | |
| 18 t.add_cleanup(() => w.tearDown()); | |
| 19 t.step(() => f(t, w)); | |
| 20 }); | |
| 21 }, name); | |
| 22 } | |
| 23 | |
| 24 function test_with_window(f, name) { | |
| 25 async_test_with_window((t, w) => { | |
| 26 f(w); | |
| 27 t.done(); | |
| 28 }, name); | |
| 29 } | |
| OLD | NEW |