[Mac][Material Design] Fix BookmarkBubbleControllerTest.TestBubbleWindow

[Mac][Material Design] Fix BookmarkBubbleControllerTest.TestBubbleWindow

This change adjusts the test for containment of the bubble window in the
test browser window. Metrics have changed under Material Design, so the
bokomarks window no longer fits completely within the test browser
window.

R=avi@chromium.org
BUG=609346
Committed: https://crrev.com/4defec915ce29dba1f503057ba798a4ce2c7a27d
Cr-Commit-Position: refs/heads/master@{#391889}

[shrike, 2016-05-05 00:29:40]

avi@ - I'm not really liking this solution, but I'm not sure what else to do.
It's not clear where the delta comes from, so it's not possible to compute that
delta in the test. Interested to know what you advise.

PTAL

[Avi (use Gerrit), 2016-05-05 02:04:43]

On 2016/05/05 00:29:40, shrike wrote:
> avi@ - I'm not really liking this solution, but I'm not sure what else to do.
> It's not clear where the delta comes from, so it's not possible to compute
that
> delta in the test. Interested to know what you advise.
> 
> PTAL

I'm not sure where half of these things came from, either.

[Avi (use Gerrit), 2016-05-05 02:04:48]

https://codereview.chromium.org/1952893002/diff/1/chrome/browser/ui/cocoa/boo...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm
(right):

https://codereview.chromium.org/1952893002/diff/1/chrome/browser/ui/cocoa/boo...
chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm:124: //
parent window)
This comment seems not true any more.

https://codereview.chromium.org/1952893002/diff/1/chrome/browser/ui/cocoa/boo...
chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm:126:
EXPECT_TRUE(ui::MaterialDesignController::IsModeMaterial());
I don't understand this line; this would make the test fail on non-MD.

[shrike, 2016-05-05 17:44:03]

PTAL

https://codereview.chromium.org/1952893002/diff/1/chrome/browser/ui/cocoa/boo...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm
(right):

https://codereview.chromium.org/1952893002/diff/1/chrome/browser/ui/cocoa/boo...
chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm:124: //
parent window)
On 2016/05/05 02:04:48, Avi wrote:
> This comment seems not true any more.

Fixed.

https://codereview.chromium.org/1952893002/diff/1/chrome/browser/ui/cocoa/boo...
chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm:126:
EXPECT_TRUE(ui::MaterialDesignController::IsModeMaterial());
On 2016/05/05 02:04:48, Avi wrote:
> I don't understand this line; this would make the test fail on non-MD.

Thank you for catching that - that should not have been included in the changes.

[Avi (use Gerrit), 2016-05-05 18:18:46]

LGTM

[shrike, 2016-05-05 18:20:01]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2016-05-05 18:20:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952893002/20001

[commit-bot: I haz the power, 2016-05-05 20:16:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-05 20:18:05]

Description was changed from

==========
[Mac][Material Design] Fix BookmarkBubbleControllerTest.TestBubbleWindow

This change adjusts the test for containment of the bubble window in the
test browser window. Metrics have changed under Material Design, so the
bokomarks window no longer fits completely within the test browser
window.

R=avi@chromium.org
BUG=609346
==========

to

==========
[Mac][Material Design] Fix BookmarkBubbleControllerTest.TestBubbleWindow

This change adjusts the test for containment of the bubble window in the
test browser window. Metrics have changed under Material Design, so the
bokomarks window no longer fits completely within the test browser
window.

R=avi@chromium.org
BUG=609346

Committed: https://crrev.com/4defec915ce29dba1f503057ba798a4ce2c7a27d
Cr-Commit-Position: refs/heads/master@{#391889}
==========

[commit-bot: I haz the power, 2016-05-05 20:18:06]

Patchset 2 (id:??) landed as
https://crrev.com/4defec915ce29dba1f503057ba798a4ce2c7a27d
Cr-Commit-Position: refs/heads/master@{#391889}