Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 1952893002: [Mac][Material Design] Fix BookmarkBubbleControllerTest.TestBubbleWindow (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Fix BookmarkBubbleControllerTest.TestBubbleWindow This change adjusts the test for containment of the bubble window in the test browser window. Metrics have changed under Material Design, so the bokomarks window no longer fits completely within the test browser window. R=avi@chromium.org BUG=609346 Committed: https://crrev.com/4defec915ce29dba1f503057ba798a4ce2c7a27d Cr-Commit-Position: refs/heads/master@{#391889}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove test code, update comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 1 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 4 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
shrike
avi@ - I'm not really liking this solution, but I'm not sure what else to ...
4 years, 7 months ago (2016-05-05 00:29:40 UTC) #1
Avi (use Gerrit)
On 2016/05/05 00:29:40, shrike wrote: > avi@ - I'm not really liking this solution, but ...
4 years, 7 months ago (2016-05-05 02:04:43 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/1952893002/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm (right): https://codereview.chromium.org/1952893002/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm#newcode124 chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm:124: // parent window) This comment seems not true any ...
4 years, 7 months ago (2016-05-05 02:04:48 UTC) #3
shrike
PTAL https://codereview.chromium.org/1952893002/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm (right): https://codereview.chromium.org/1952893002/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm#newcode124 chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm:124: // parent window) On 2016/05/05 02:04:48, Avi wrote: ...
4 years, 7 months ago (2016-05-05 17:44:03 UTC) #4
Avi (use Gerrit)
LGTM
4 years, 7 months ago (2016-05-05 18:18:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952893002/20001
4 years, 7 months ago (2016-05-05 18:20:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-05 20:16:40 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 20:18:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4defec915ce29dba1f503057ba798a4ce2c7a27d
Cr-Commit-Position: refs/heads/master@{#391889}

Powered by Google App Engine
This is Rietveld 408576698