Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 1952863004: Revert of Try to build 'gn_all' on Win x64 builders. (Closed)

Created:
4 years, 7 months ago by jam
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Try to build 'gn_all' on Win x64 builders. (patchset #2 id:20001 of https://codereview.chromium.org/1926723003/ ) Reason for revert: To see if windows bots' cycle time recovers. Original issue's description: > Try to build 'gn_all' on Win x64 builders. > > This CL adds the 'gn_all' additional_compile_target to > 'Win x64 Builder' and 'Win x64 Builder (dbg)'; the former will > get mirrored onto 'win_chromium_x64_rel_ng' in the CQ as well. > > This should allow us to catch a lot more of the compile-related issues > that seem to be cropping up as we switch the bots to GN. > > This will likely increase the cycle times for the builder in the > CQ, but we don't know by how much. > > We don't build 'all' because of crbug.com/555273. In theory, gn_all > should build everything that all does except for stamp files (any discrepancy is a bug), but in practice we're probably missing some things and need to hunt them down. > > R=jam@chromium.org, brucedawson@chromium.org, thakis@chromium.org > BUG=605318 > > Committed: https://crrev.com/9711369180264c97e942e0b6be83c3e17db5e326 > Cr-Commit-Position: refs/heads/master@{#390488} TBR=brucedawson@chromium.org,thakis@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605318 Committed: https://crrev.com/f414e44aac0f359a551409d4db5cd904742ec145 Cr-Commit-Position: refs/heads/master@{#391901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -2 lines) Patch
M testing/buildbot/chromium.win.json View 1 chunk +436 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jam
Created Revert of Try to build 'gn_all' on Win x64 builders.
4 years, 7 months ago (2016-05-05 19:56:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952863004/1
4 years, 7 months ago (2016-05-05 19:56:49 UTC) #2
Dirk Pranke
lgtm. I'm sorry I didn't catch the uptick in load earlier, I've been too distracted ...
4 years, 7 months ago (2016-05-05 20:28:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 21:31:28 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 21:33:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f414e44aac0f359a551409d4db5cd904742ec145
Cr-Commit-Position: refs/heads/master@{#391901}

Powered by Google App Engine
This is Rietveld 408576698