Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1952863003: Implemented the "aria-current" state on Windows. (Closed)

Created:
4 years, 7 months ago by nektarios
Modified:
4 years, 7 months ago
CC:
aboxhall, aboxhall+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, dmazzoni, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, haraken, jam, je_julie, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nektarios, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implemented the "aria-current" state on Windows. BUG=609362 TESTED=browser test R=dmazzoni@chromium.org,cbiesinger@chromium.org,dglazkov@chromium.org Committed: https://crrev.com/56b59384d738a34666efad6fc8aa87176e8c0f31 Cr-Commit-Position: refs/heads/master@{#392462}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changed to using the AriaCurrentState instead of AriaCurrent and updated test expectations. #

Patch Set 3 : Fixed compilation errors. #

Patch Set 4 : Fixed small compiler error. #

Patch Set 5 : Fixed switch statements to handle NONE case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -20 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 3 4 7 chunks +34 lines, -11 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.h View 1 1 chunk +3 lines, -6 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 2 chunks +26 lines, -2 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-current.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-current-expected-win.txt View 1 1 chunk +16 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-invalid.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.in View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 2 chunks +28 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 1 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebAXEnums.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebAXObject.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 2 chunks +14 lines, -0 lines 0 comments Download
M ui/accessibility/ax_node_data.cc View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M ui/accessibility/ax_tree_combiner.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
nektarios
4 years, 7 months ago (2016-05-05 02:02:57 UTC) #1
dmazzoni
lgtm https://codereview.chromium.org/1952863003/diff/1/content/test/data/accessibility/aria/aria-current-expected-win.txt File content/test/data/accessibility/aria/aria-current-expected-win.txt (right): https://codereview.chromium.org/1952863003/diff/1/content/test/data/accessibility/aria/aria-current-expected-win.txt#newcode1 content/test/data/accessibility/aria/aria-current-expected-win.txt:1: ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE ia2_hypertext='<obj0><obj1><obj2><obj3>' Needs to be updated?
4 years, 7 months ago (2016-05-05 20:19:01 UTC) #2
nektarios
@dmazzoni I changed the name of all related methods and enums to AriaCurrentState from AriaCurrent. ...
4 years, 7 months ago (2016-05-06 00:03:30 UTC) #6
dglazkov
lgtm
4 years, 7 months ago (2016-05-09 16:44:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952863003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952863003/20001
4 years, 7 months ago (2016-05-09 16:46:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/62797) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-09 16:57:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952863003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952863003/40001
4 years, 7 months ago (2016-05-09 18:53:22 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/157329) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-09 19:03:01 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952863003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952863003/60001
4 years, 7 months ago (2016-05-09 19:10:13 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/18734)
4 years, 7 months ago (2016-05-09 20:54:53 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952863003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952863003/80001
4 years, 7 months ago (2016-05-09 21:34:21 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-09 23:05:13 UTC) #27
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 23:06:50 UTC) #29
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/56b59384d738a34666efad6fc8aa87176e8c0f31
Cr-Commit-Position: refs/heads/master@{#392462}

Powered by Google App Engine
This is Rietveld 408576698