[MD settings] unit test for settings-menu

[MD settings] unit test for settings-menu

This CL add some basic tests for settings-menu.

BUG=593989
Committed: https://crrev.com/c91001b6a3ba733e8500548a706196e394a44be8
Cr-Commit-Position: refs/heads/master@{#391866}

[dschuyler, 2016-05-04 23:39:30]

Patchset #1 (id:1) has been deleted

[dschuyler, 2016-05-04 23:39:53]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2016-05-05 00:11:30]

https://codereview.chromium.org/1952863002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_menu_test.js (right):

https://codereview.chromium.org/1952863002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_menu_test.js:22:
assertFalse(!!settingsMenu.$.advancedPage.opened);
paper-submenu#opened property is a boolean already, so there is no need to
double-negate it (which is a trick for converting a non-boolean to a boolean
value). Same below.

https://codereview.chromium.org/1952863002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_menu_test.js:33: });
Optional: Can we add a test for the case where currentRoute has a 'section' and
assert that the correct entry is "selected"?

[dschuyler, 2016-05-05 00:23:49]

https://codereview.chromium.org/1952863002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_menu_test.js (right):

https://codereview.chromium.org/1952863002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_menu_test.js:22:
assertFalse(!!settingsMenu.$.advancedPage.opened);
On 2016/05/05 00:11:29, dpapad wrote:
> paper-submenu#opened property is a boolean already, so there is no need to
> double-negate it (which is a trick for converting a non-boolean to a boolean
> value). Same below.

Done.

https://codereview.chromium.org/1952863002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_menu_test.js:33: });
On 2016/05/05 00:11:29, dpapad wrote:
> Optional: Can we add a test for the case where currentRoute has a 'section'
and
> assert that the correct entry is "selected"?

Done.

[dpapad, 2016-05-05 00:35:54]

LGTM! Thanks for adding these tests.

[dschuyler, 2016-05-05 18:13:22]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-05-05 18:13:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952863002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952863002/40001

[commit-bot: I haz the power, 2016-05-05 19:18:32]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-05 19:21:17]

Description was changed from

==========
[MD settings] unit test for settings-menu

This CL add some basic tests for settings-menu.

BUG=593989
==========

to

==========
[MD settings] unit test for settings-menu

This CL add some basic tests for settings-menu.

BUG=593989

Committed: https://crrev.com/c91001b6a3ba733e8500548a706196e394a44be8
Cr-Commit-Position: refs/heads/master@{#391866}
==========

[commit-bot: I haz the power, 2016-05-05 19:21:17]

Patchset 2 (id:??) landed as
https://crrev.com/c91001b6a3ba733e8500548a706196e394a44be8
Cr-Commit-Position: refs/heads/master@{#391866}