Skeleton of the overall design for the database for Pver4

components/safe_browsing_db/v4_database_impl.cc

Index: components/safe_browsing_db/v4_database_impl.cc
diff --git a/components/safe_browsing_db/v4_database_impl.cc b/components/safe_browsing_db/v4_database_impl.cc
new file mode 100644
index 0000000000000000000000000000000000000000..198d9738777a35cefa55cee62d75c79a6275794e
--- /dev/null
+++ b/components/safe_browsing_db/v4_database_impl.cc
@@ -0,0 +1,34 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/safe_browsing_db/v4_database_impl.h"
+
+#include "components/safe_browsing_db/v4_protocol_manager_util.h"
+#include "components/safe_browsing_db/v4_store.h"
+
+namespace safe_browsing {
+
+class V4DatabaseImpl;
+
+// The default V4DatabaseFactory.
+class V4DatabaseFactoryImpl : public V4DatabaseFactory {

[Nathan Parker, 2016/05/05 18:26:44]

I think you could do without a default factory, by having a static
V4DatabaseFactory::Create() method that checks if a global factory is set (would
be for tests) and if not, just does the new V4DatabaseImpl.  That makes it very
clear what the default behaviour is.

[vakh (use Gerrit instead), 2016/05/06 00:23:15]

Done.

+ public:
+  V4Database* CreateV4Database(
+      const scoped_refptr<base::SequencedTaskRunner>& db_task_runner,
+      bool enable_malware_list,
+      bool enable_phishing_list,
+      bool enable_unwanted_software_list) override {
+    StoreMap store_map;
+    return new V4DatabaseImpl(db_task_runner, std::move(store_map));
+  }
+
+  V4DatabaseFactoryImpl() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(V4DatabaseFactoryImpl);
+};
+
+
+
+}  // namespace safe_browsing