Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1952823002: Copy the event definition file to the testing directory along with pdf (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Copy the event definition file to the testing directory along with pdf data_binding.pdf is much closer now that events are sent. It still diffs due to some bg color issues, not that the box is unchecked. Committed: https://pdfium.googlesource.com/pdfium/+/d7725bb53c7593c42579a28dd5947a8b8e13949f

Patch Set 1 #

Patch Set 2 : winders #

Patch Set 3 : Try it on windows just for laughs #

Patch Set 4 : Suppress them again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M testing/tools/run_corpus_tests.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Dan, baby steps. Thanks.
4 years, 7 months ago (2016-05-04 21:56:00 UTC) #2
dsinclair
lgtm
4 years, 7 months ago (2016-05-04 23:20:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952823002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952823002/60001
4 years, 7 months ago (2016-05-04 23:20:20 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 23:20:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/d7725bb53c7593c42579a28dd5947a8b8e13...

Powered by Google App Engine
This is Rietveld 408576698