build/android/pylib/local/device/local_device_instrumentation_test_run.py - Issue 1952813002: [Android] Set permissions when clearing app state in test runner platform mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 1952813002: [Android] Set permissions when clearing app state in test runner platform mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix issue with presubmit Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py

diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

index fd7cfbbad34d80352cac2630712f3eeeac0e139f..9714a97e644299c08d0c6f85ebbeaa4ff8c21237 100644

--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py

+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

@@ -268,7 +268,13 @@ class LocalDeviceInstrumentationTestRun(

logging.info(' %s', l)

if (not self._env.skip_clear_data

and self._test_instance.package_info):

- device.ClearApplicationState(self._test_instance.package_info.package)

+ permissions = (

+ self._test_instance.apk_under_test

jbudorick 2016/05/10 23:23:29 I think this is backwards.

rnephew (Reviews Here) 2016/05/10 23:27:33 Done.

+ if self._test_instance.apk_under_test.GetPermissions()

+ else None)

+ device.ClearApplicationState(self._test_instance.package_info.package,

+ permissions=permissions)

else:

logging.debug('raw output from %s:', test_display_name)

for l in output:

« no previous file with comments | « no previous file | no next file » | no next file with comments »