Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1952813002: [Android] Set permissions when clearing app state in test runner platform mode. (Closed)

Created:
4 years, 7 months ago by rnephew (Reviews Here)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Set permissions when clearing app state in test runner platform mode. BUG=609226 Committed: https://crrev.com/7b6552417873165924fd7f62cc428fe5e6b12dc1 Cr-Commit-Position: refs/heads/master@{#392871}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix whitespace #

Total comments: 1

Patch Set 3 : fix issue with presubmit #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
rnephew (Reviews Here)
https://codereview.chromium.org/1952813002/diff/1/build/android/test_runner.pydeps File build/android/test_runner.pydeps (left): https://codereview.chromium.org/1952813002/diff/1/build/android/test_runner.pydeps#oldcode6 build/android/test_runner.pydeps:6: ../../third_party/appurify-python/src/appurify/utils.py Not sure why I had to run this... ...
4 years, 7 months ago (2016-05-04 20:56:47 UTC) #2
jbudorick
https://codereview.chromium.org/1952813002/diff/20001/build/android/test_runner.pydeps File build/android/test_runner.pydeps (left): https://codereview.chromium.org/1952813002/diff/20001/build/android/test_runner.pydeps#oldcode3 build/android/test_runner.pydeps:3: ../../third_party/appurify-python/src/appurify/__init__.py This probably isn't right?
4 years, 7 months ago (2016-05-04 20:59:45 UTC) #3
rnephew (Reviews Here)
On 2016/05/04 20:59:45, jbudorick wrote: > https://codereview.chromium.org/1952813002/diff/20001/build/android/test_runner.pydeps > File build/android/test_runner.pydeps (left): > > https://codereview.chromium.org/1952813002/diff/20001/build/android/test_runner.pydeps#oldcode3 > ...
4 years, 7 months ago (2016-05-04 21:02:05 UTC) #4
jbudorick
On 2016/05/04 21:02:05, rnephew1 wrote: > On 2016/05/04 20:59:45, jbudorick wrote: > > > https://codereview.chromium.org/1952813002/diff/20001/build/android/test_runner.pydeps ...
4 years, 7 months ago (2016-05-04 21:22:26 UTC) #5
jbudorick
https://codereview.chromium.org/1952813002/diff/40001/build/android/pylib/local/device/local_device_instrumentation_test_run.py File build/android/pylib/local/device/local_device_instrumentation_test_run.py (right): https://codereview.chromium.org/1952813002/diff/40001/build/android/pylib/local/device/local_device_instrumentation_test_run.py#newcode272 build/android/pylib/local/device/local_device_instrumentation_test_run.py:272: self._test_instance.apk_under_test I think this is backwards.
4 years, 7 months ago (2016-05-10 23:23:29 UTC) #6
rnephew (Reviews Here)
https://codereview.chromium.org/1952813002/diff/40001/build/android/pylib/local/device/local_device_instrumentation_test_run.py File build/android/pylib/local/device/local_device_instrumentation_test_run.py (right): https://codereview.chromium.org/1952813002/diff/40001/build/android/pylib/local/device/local_device_instrumentation_test_run.py#newcode272 build/android/pylib/local/device/local_device_instrumentation_test_run.py:272: self._test_instance.apk_under_test On 2016/05/10 23:23:29, jbudorick wrote: > I think ...
4 years, 7 months ago (2016-05-10 23:27:33 UTC) #7
jbudorick
lgtm
4 years, 7 months ago (2016-05-11 03:04:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952813002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952813002/60001
4 years, 7 months ago (2016-05-11 06:25:19 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-11 07:22:24 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 07:24:00 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7b6552417873165924fd7f62cc428fe5e6b12dc1
Cr-Commit-Position: refs/heads/master@{#392871}

Powered by Google App Engine
This is Rietveld 408576698