Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/modules/webaudio/PannerNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move more things to Node::create() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/PannerNode.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/PannerNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webaudio/PannerNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/PannerNode.h b/third_party/WebKit/Source/modules/webaudio/PannerNode.h
index a12095ebb48de6c9a4025fd4f7f208b8211d8fe4..44d8576871a464f62c156d95601cc36c89917fd2 100644
--- a/third_party/WebKit/Source/modules/webaudio/PannerNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/PannerNode.h
@@ -148,7 +148,7 @@ private:
class PannerNode final : public AudioNode {
DEFINE_WRAPPERTYPEINFO();
public:
- static PannerNode* create(AbstractAudioContext&, float sampleRate);
+ static PannerNode* create(AbstractAudioContext&, ExceptionState&);
PannerHandler& pannerHandler() const;
String panningModel() const;
@@ -172,7 +172,7 @@ public:
void setConeOuterGain(double);
private:
- PannerNode(AbstractAudioContext&, float sampleRate);
+ PannerNode(AbstractAudioContext&);
};
} // namespace blink
« third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/PannerNode.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/PannerNode.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698