third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h - Issue 1952793002: Move the exception logic to the AudioNode creator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h

index 4786ec40031f7e181f37b4c785ddc991c47eae72..da461bcb74d3a34f34a98f0ea136599337268614 100644

--- a/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h

@@ -73,7 +73,7 @@ class MediaStreamAudioSourceNode final : public AudioSourceNode, public AudioSou

DEFINE_WRAPPERTYPEINFO();

USING_GARBAGE_COLLECTED_MIXIN(MediaStreamAudioSourceNode);

public:

- static MediaStreamAudioSourceNode* create(AbstractAudioContext&, MediaStream&, MediaStreamTrack*, PassOwnPtr<AudioSourceProvider>);

+ static MediaStreamAudioSourceNode* create(AbstractAudioContext&, MediaStream&, ExceptionState&);

DECLARE_VIRTUAL_TRACE();

MediaStreamAudioSourceHandler& mediaStreamAudioSourceHandler() const;