third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h - Issue 1952793002: Move the exception logic to the AudioNode creator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h

index 63e8a8dcd1712f71b2f1c2e07c5d041d714b59f2..c0181005027640c02f3376ee13f3c85fa44f3fe4 100644

--- a/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h

@@ -100,7 +100,7 @@ class MediaElementAudioSourceNode final : public AudioSourceNode, public AudioSo

DEFINE_WRAPPERTYPEINFO();

USING_GARBAGE_COLLECTED_MIXIN(MediaElementAudioSourceNode);

public:

- static MediaElementAudioSourceNode* create(AbstractAudioContext&, HTMLMediaElement&);

+ static MediaElementAudioSourceNode* create(AbstractAudioContext&, HTMLMediaElement&, ExceptionState&);

DECLARE_VIRTUAL_TRACE();

MediaElementAudioSourceHandler& mediaElementAudioSourceHandler() const;