Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h b/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h
index b25f0581db935babe1b27b1b2406f3c5f049ca17..761e7e3ffa9d29b06aa20aa6249ad6bf0e5cea27 100644
--- a/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h
@@ -17,10 +17,12 @@ class ExceptionState;
class IIRFilterNode : public AudioNode {
DEFINE_WRAPPERTYPEINFO();
public:
- static IIRFilterNode* create(AbstractAudioContext& context, float sampleRate, const Vector<double> feedforward, const Vector<double> feedback)
- {
- return new IIRFilterNode(context, sampleRate, feedforward, feedback);
- }
+ static IIRFilterNode* create(
+ AbstractAudioContext&,
+ const Vector<double> feedforward,
+ const Vector<double> feedback,
+ ExceptionState&);
+
DECLARE_VIRTUAL_TRACE();
// Get the magnitude and phase response of the filter at the given
@@ -28,7 +30,7 @@ public:
void getFrequencyResponse(const DOMFloat32Array* frequencyHz, DOMFloat32Array* magResponse, DOMFloat32Array* phaseResponse, ExceptionState&);
private:
- IIRFilterNode(AbstractAudioContext&, float sampleRate, const Vector<double> denominator, const Vector<double> numerator);
+ IIRFilterNode(AbstractAudioContext&, const Vector<double> denominator, const Vector<double> numerator);
IIRProcessor* iirProcessor() const;
};
« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/GainNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698