Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: third_party/WebKit/Source/modules/webaudio/ConvolverNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/ConvolverNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h
index 7ad656e1d576f90d6e9bf145c8eedb8c6454e0b2..294fde6d53a56570f4535af10aa2cf0a0cff7d96 100644
--- a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h
@@ -75,7 +75,7 @@ private:
class MODULES_EXPORT ConvolverNode final : public AudioNode {
DEFINE_WRAPPERTYPEINFO();
public:
- static ConvolverNode* create(AbstractAudioContext&, float sampleRate);
+ static ConvolverNode* create(AbstractAudioContext&, ExceptionState&);
AudioBuffer* buffer() const;
void setBuffer(AudioBuffer*, ExceptionState&);
@@ -83,7 +83,7 @@ public:
void setNormalize(bool);
private:
- ConvolverNode(AbstractAudioContext&, float sampleRate);
+ ConvolverNode(AbstractAudioContext&);
ConvolverHandler& convolverHandler() const;
FRIEND_TEST_ALL_PREFIXES(ConvolverNodeTest, ReverbLifetime);

Powered by Google App Engine
This is Rietveld 408576698