Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp b/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp
index b2f54cefc4b5ea1c6800d20057155562928d7221..ecdecdbc15be26daa6a123ea6b339d1358b5f79b 100644
--- a/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp
@@ -119,17 +119,43 @@ void ChannelMergerHandler::setChannelCountMode(const String& mode, ExceptionStat
// ----------------------------------------------------------------
-ChannelMergerNode::ChannelMergerNode(AbstractAudioContext& context, float sampleRate, unsigned numberOfInputs)
+ChannelMergerNode::ChannelMergerNode(AbstractAudioContext& context, unsigned numberOfInputs)
: AudioNode(context)
{
- setHandler(ChannelMergerHandler::create(*this, sampleRate, numberOfInputs));
+ setHandler(ChannelMergerHandler::create(*this, context.sampleRate(), numberOfInputs));
}
-ChannelMergerNode* ChannelMergerNode::create(AbstractAudioContext& context, float sampleRate, unsigned numberOfInputs)
+ChannelMergerNode* ChannelMergerNode::create(AbstractAudioContext& context, ExceptionState& exceptionState)
{
- if (!numberOfInputs || numberOfInputs > AbstractAudioContext::maxNumberOfChannels())
+ DCHECK(isMainThread());
+
+ // The default number of inputs for the merger node is 6.
+ return create(context, 6, exceptionState);
+}
+
+ChannelMergerNode* ChannelMergerNode::create(AbstractAudioContext& context, unsigned numberOfInputs, ExceptionState& exceptionState)
+{
+ DCHECK(isMainThread());
+
+ if (context.isContextClosed()) {
+ context.throwExceptionForClosedState(exceptionState);
return nullptr;
- return new ChannelMergerNode(context, sampleRate, numberOfInputs);
+ }
+
+ if (!numberOfInputs || numberOfInputs > AbstractAudioContext::maxNumberOfChannels()) {
+ exceptionState.throwDOMException(
+ IndexSizeError,
+ ExceptionMessages::indexOutsideRange<size_t>(
+ "number of inputs",
+ numberOfInputs,
+ 1,
+ ExceptionMessages::InclusiveBound,
+ AbstractAudioContext::maxNumberOfChannels(),
+ ExceptionMessages::InclusiveBound));
+ return nullptr;
+ }
+
+ return new ChannelMergerNode(context, numberOfInputs);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698