Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.h b/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.h
index 111962956df18eb8c54e046b54fbc4d2a456fc56..f75c80cfbf9f405098d1d3422d50502fb4af3b78 100644
--- a/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.h
@@ -49,10 +49,8 @@ public:
ALLPASS = 7
};
- static BiquadFilterNode* create(AbstractAudioContext& context, float sampleRate)
- {
- return new BiquadFilterNode(context, sampleRate);
- }
+ static BiquadFilterNode* create(AbstractAudioContext&, ExceptionState&);
+
DECLARE_VIRTUAL_TRACE();
String type() const;
@@ -68,7 +66,7 @@ public:
void getFrequencyResponse(const DOMFloat32Array* frequencyHz, DOMFloat32Array* magResponse, DOMFloat32Array* phaseResponse);
private:
- BiquadFilterNode(AbstractAudioContext&, float sampleRate);
+ BiquadFilterNode(AbstractAudioContext&);
BiquadProcessor* getBiquadProcessor() const;
bool setType(unsigned); // Returns true on success.

Powered by Google App Engine
This is Rietveld 408576698