third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h - Issue 1952793002: Move the exception logic to the AudioNode creator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h

index 8b355ba1af854166780918560ec63510c27eb731..35f1c1e49b95b80a79fd1df1f6d7359e9c0a0d46 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h

@@ -141,7 +141,7 @@ private:

class AudioBufferSourceNode final : public AudioScheduledSourceNode {

DEFINE_WRAPPERTYPEINFO();

public:

- static AudioBufferSourceNode* create(AbstractAudioContext&, float sampleRate);

+ static AudioBufferSourceNode* create(AbstractAudioContext&, ExceptionState&);

DECLARE_VIRTUAL_TRACE();

AudioBufferSourceHandler& audioBufferSourceHandler() const;

@@ -162,7 +162,7 @@ public:

void start(double when, double grainOffset, double grainDuration, ExceptionState&);

private:

- AudioBufferSourceNode(AbstractAudioContext&, float sampleRate);

+ AudioBufferSourceNode(AbstractAudioContext&);

Member<AudioParam> m_playbackRate;

Member<AudioParam> m_detune;