third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h - Issue 1952793002: Move the exception logic to the AudioNode creator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address some review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/PeriodicWave.cpp ('k') | third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h b/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

index a77b52e67394f076d8e5017ff9b2ea43dfc8022b..b575982fd1024a5928ec8179779a095cdfb0683c 100644

--- a/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

@@ -103,7 +103,15 @@ public:

// latency. Higher numbers will be necessary to avoid audio breakup and

// glitches.

// The value chosen must carefully balance between latency and audio quality.

- static ScriptProcessorNode* create(AbstractAudioContext&, float sampleRate, size_t bufferSize, unsigned numberOfInputChannels, unsigned numberOfOutputChannels);

+ static ScriptProcessorNode* create(AbstractAudioContext&, ExceptionState&);

+ static ScriptProcessorNode* create(AbstractAudioContext&, size_t bufferSize, ExceptionState&);

+ static ScriptProcessorNode* create(AbstractAudioContext&, size_t bufferSize, unsigned numberOfInputChannels, ExceptionState&);

+ static ScriptProcessorNode* create(

+ AbstractAudioContext&,

+ size_t bufferSize,

+ unsigned numberOfInputChannels,

+ unsigned numberOfOutputChannels,

+ ExceptionState&);

DEFINE_ATTRIBUTE_EVENT_LISTENER(audioprocess);

size_t bufferSize() const;