Move the exception logic to the AudioNode creator

third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 85 matching lines @@
     USING_GARBAGE_COLLECTED_MIXIN(ScriptProcessorNode);
 public:
     // bufferSize must be one of the following values: 256, 512, 1024, 2048,
     // 4096, 8192, 16384.
     // This value controls how frequently the onaudioprocess event handler is
     // called and how many sample-frames need to be processed each call.
     // Lower numbers for bufferSize will result in a lower (better)
     // latency. Higher numbers will be necessary to avoid audio breakup and
     // glitches.
     // The value chosen must carefully balance between latency and audio quality.
-    static ScriptProcessorNode* create(AbstractAudioContext&, float sampleRate, size_t bufferSize, unsigned numberOfInputChannels, unsigned numberOfOutputChannels);
+    static ScriptProcessorNode* create(AbstractAudioContext&, ExceptionState&);
+    static ScriptProcessorNode* create(AbstractAudioContext&, size_t bufferSize, ExceptionState&);
+    static ScriptProcessorNode* create(AbstractAudioContext&, size_t bufferSize, unsigned numberOfInputChannels, ExceptionState&);
+    static ScriptProcessorNode* create(
+        AbstractAudioContext&,
+        size_t bufferSize,
+        unsigned numberOfInputChannels,
+        unsigned numberOfOutputChannels,
+        ExceptionState&);

[hongchan, 2016/05/13 01:20:13]

Let's make this consistent (by wrapping around 80 cols).

[hongchan, 2016/05/20 21:28:32]

Can you take one more look on this?

[Raymond Toy, 2016/05/20 21:46:10]

What kind of consistency?  Just wrap line 108 to 80 cols (which isn't required)?
 Unwrap line 109-114 to 80 cols?

Make line 108 look like 109-114?  What about 107 and 106?

[hongchan, 2016/05/20 22:57:48]

Which style do you want to have here? wrapped or unwrapped? It's up to you - I
just want them to be consistent.

 
     DEFINE_ATTRIBUTE_EVENT_LISTENER(audioprocess);
     size_t bufferSize() const;
 
     // ActiveScriptWrappable
     bool hasPendingActivity() const final;
 
     DEFINE_INLINE_VIRTUAL_TRACE() { AudioNode::trace(visitor); }
 
 private:
     ScriptProcessorNode(AbstractAudioContext&, float sampleRate, size_t bufferSize, unsigned numberOfInputChannels, unsigned numberOfOutputChannels);
 };
 
 } // namespace blink
 
 #endif // ScriptProcessorNode_h