Move the exception logic to the AudioNode creator

third_party/WebKit/Source/modules/webaudio/PannerNode.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 476 matching lines @@
         // Do nothing for other invalid values.
         m_newChannelCountMode = oldMode;
     }
 
     if (m_newChannelCountMode != oldMode)
         context()->deferredTaskHandler().addChangedChannelCountMode(this);
 }
 
 // ----------------------------------------------------------------
 
-PannerNode::PannerNode(AbstractAudioContext& context, float sampelRate)
+PannerNode::PannerNode(AbstractAudioContext& context)
     : AudioNode(context)
 {
-    setHandler(PannerHandler::create(*this, sampelRate));
+    setHandler(PannerHandler::create(*this, context.sampleRate()));
 }
 
-PannerNode* PannerNode::create(AbstractAudioContext& context, float sampleRate)
+PannerNode* PannerNode::create(AbstractAudioContext& context, ExceptionState& exceptionState)

[hongchan, 2016/05/13 01:20:12]

Over 80 cols.

 {
-    return new PannerNode(context, sampleRate);
+    ASSERT(isMainThread());

[hongchan, 2016/05/13 01:20:12]

DCHECK.

[Raymond Toy, 2016/05/20 23:12:01]

Done.

+
+    if (context.isContextClosed()) {
+        context.throwExceptionForClosedState(exceptionState);
+        return nullptr;
+    }
+
+    return new PannerNode(context);
 }
 
 PannerHandler& PannerNode::pannerHandler() const
 {
     return static_cast<PannerHandler&>(handler());
 }
 
 String PannerNode::panningModel() const
 {
     return pannerHandler().panningModel();
@@ skipping 84 matching lines @@
 {
     return pannerHandler().coneOuterGain();
 }
 
 void PannerNode::setConeOuterGain(double gain)
 {
     pannerHandler().setConeOuterGain(gain);
 }
 
 } // namespace blink