Move the exception logic to the AudioNode creator

third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp

 /*
  * Copyright (C) 2012, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 312 matching lines @@
     m_type = CUSTOM;
 }
 
 bool OscillatorHandler::propagatesSilence() const
 {
     return !isPlayingOrScheduled() || hasFinished() || !m_periodicWave.get();
 }
 
 // ----------------------------------------------------------------
 
-OscillatorNode::OscillatorNode(AbstractAudioContext& context, float sampleRate)
+OscillatorNode::OscillatorNode(AbstractAudioContext& context)
     : AudioScheduledSourceNode(context)
     // Use musical pitch standard A440 as a default.
     , m_frequency(AudioParam::create(context, ParamTypeOscillatorFrequency, 440))
     // Default to no detuning.
     , m_detune(AudioParam::create(context, ParamTypeOscillatorDetune, 0))
 {
-    setHandler(OscillatorHandler::create(*this, sampleRate, m_frequency->handler(), m_detune->handler()));
+    setHandler(OscillatorHandler::create(*this, context.sampleRate(), m_frequency->handler(), m_detune->handler()));

[hongchan, 2016/05/13 01:20:12]

Over 80 cols. Let's wrap this!

 }
 
-OscillatorNode* OscillatorNode::create(AbstractAudioContext& context, float sampleRate)
+OscillatorNode* OscillatorNode::create(AbstractAudioContext& context, ExceptionState& exceptionState)

[hongchan, 2016/05/13 01:20:12]

Over 80 cols.

 {
-    return new OscillatorNode(context, sampleRate);
+    ASSERT(isMainThread());

[hongchan, 2016/05/13 01:20:12]

DCHECK.

+
+    if (context.isContextClosed()) {
+        context.throwExceptionForClosedState(exceptionState);
+        return nullptr;
+    }
+
+    return new OscillatorNode(context);
 }
 
 DEFINE_TRACE(OscillatorNode)
 {
     visitor->trace(m_frequency);
     visitor->trace(m_detune);
     AudioScheduledSourceNode::trace(visitor);
 }
 
 OscillatorHandler& OscillatorNode::oscillatorHandler() const
@@ skipping 21 matching lines @@
     return m_detune;
 }
 
 void OscillatorNode::setPeriodicWave(PeriodicWave* wave)
 {
     oscillatorHandler().setPeriodicWave(wave);
 }
 
 } // namespace blink