Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move more things to Node::create() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 } 115 }
116 116
117 // ---------------------------------------------------------------- 117 // ----------------------------------------------------------------
118 118
119 MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode(AbstractAudioCo ntext& context, size_t numberOfChannels) 119 MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode(AbstractAudioCo ntext& context, size_t numberOfChannels)
120 : AudioBasicInspectorNode(context) 120 : AudioBasicInspectorNode(context)
121 { 121 {
122 setHandler(MediaStreamAudioDestinationHandler::create(*this, numberOfChannel s)); 122 setHandler(MediaStreamAudioDestinationHandler::create(*this, numberOfChannel s));
123 } 123 }
124 124
125 MediaStreamAudioDestinationNode* MediaStreamAudioDestinationNode::create(Abstrac tAudioContext& context, size_t numberOfChannels) 125 MediaStreamAudioDestinationNode* MediaStreamAudioDestinationNode::create(Abstrac tAudioContext& context, size_t numberOfChannels, ExceptionState& exceptionState)
126 { 126 {
127 ASSERT(isMainThread());
hongchan 2016/05/13 01:20:12 DCHECK.
Raymond Toy 2016/05/20 23:12:00 Done.
128
129 if (context.isContextClosed()) {
130 context.throwExceptionForClosedState(exceptionState);
131 return nullptr;
132 }
133
127 return new MediaStreamAudioDestinationNode(context, numberOfChannels); 134 return new MediaStreamAudioDestinationNode(context, numberOfChannels);
128 } 135 }
129 136
130 MediaStream* MediaStreamAudioDestinationNode::stream() const 137 MediaStream* MediaStreamAudioDestinationNode::stream() const
131 { 138 {
132 return static_cast<MediaStreamAudioDestinationHandler&>(handler()).stream(); 139 return static_cast<MediaStreamAudioDestinationHandler&>(handler()).stream();
133 } 140 }
134 141
135 } // namespace blink 142 } // namespace blink
136 143
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698