Move the exception logic to the AudioNode creator

third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 147 matching lines @@
     MutexTryLocker tryLocker(m_processLock);
     if (tryLocker.locked())
         return m_reverb ? m_reverb->latencyFrames() / static_cast<double>(sampleRate()) : 0;
     // Since we don't want to block the Audio Device thread, we return a large value
     // instead of trying to acquire the lock.
     return std::numeric_limits<double>::infinity();
 }
 
 // ----------------------------------------------------------------
 
-ConvolverNode::ConvolverNode(AbstractAudioContext& context, float sampleRate)
+ConvolverNode::ConvolverNode(AbstractAudioContext& context)
     : AudioNode(context)
 {
-    setHandler(ConvolverHandler::create(*this, sampleRate));
+    setHandler(ConvolverHandler::create(*this, context.sampleRate()));
 }
 
-ConvolverNode* ConvolverNode::create(AbstractAudioContext& context, float sampleRate)
+ConvolverNode* ConvolverNode::create(AbstractAudioContext& context, ExceptionState& exceptionState)
 {
-    return new ConvolverNode(context, sampleRate);
+    ASSERT(isMainThread());

[hongchan, 2016/05/13 01:20:11]

DCHECK?

[Raymond Toy, 2016/05/20 23:12:00]

Done.

+
+    if (context.isContextClosed()) {

[hongchan, 2016/05/13 01:20:11]

Perhaps we can make this to a method? This check-and-return pattern is almost
everywhere.

[Raymond Toy, 2016/05/13 16:36:01]

I thought about that.  But we'd still have to do something like

if (context.throwIfContextClosed())
  return nullptr;

Only one line shorter.

[Raymond Toy, 2016/05/13 18:41:47]

After some further discussions, we decided it would be best handled in the
AudioNode constructor, which we will implement in a followup CL.

+        context.throwExceptionForClosedState(exceptionState);
+        return nullptr;
+    }
+
+    return new ConvolverNode(context);
 }
 
 ConvolverHandler& ConvolverNode::convolverHandler() const
 {
     return static_cast<ConvolverHandler&>(handler());
 }
 
 AudioBuffer* ConvolverNode::buffer() const
 {
     return convolverHandler().buffer();
 }
 
 void ConvolverNode::setBuffer(AudioBuffer* newBuffer, ExceptionState& exceptionState)
 {
     convolverHandler().setBuffer(newBuffer, exceptionState);
 }
 
 bool ConvolverNode::normalize() const
 {
     return convolverHandler().normalize();
 }
 
 void ConvolverNode::setNormalize(bool normalize)
 {
     convolverHandler().setNormalize(normalize);
 }
 
 } // namespace blink