Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/PannerNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 FloatPoint3D m_lastPosition; 199 FloatPoint3D m_lastPosition;
200 FloatPoint3D m_lastOrientation; 200 FloatPoint3D m_lastOrientation;
201 201
202 // Synchronize process() with setting of the panning model, source's locatio n information, listener, distance parameters and sound cones. 202 // Synchronize process() with setting of the panning model, source's locatio n information, listener, distance parameters and sound cones.
203 mutable Mutex m_processLock; 203 mutable Mutex m_processLock;
204 }; 204 };
205 205
206 class PannerNode final : public AudioNode { 206 class PannerNode final : public AudioNode {
207 DEFINE_WRAPPERTYPEINFO(); 207 DEFINE_WRAPPERTYPEINFO();
208 public: 208 public:
209 static PannerNode* create(AbstractAudioContext&, float sampleRate); 209 static PannerNode* create(AbstractAudioContext&, ExceptionState&);
210 PannerHandler& pannerHandler() const; 210 PannerHandler& pannerHandler() const;
211 211
212 DECLARE_VIRTUAL_TRACE(); 212 DECLARE_VIRTUAL_TRACE();
213 213
214 // Uses a 3D cartesian coordinate system 214 // Uses a 3D cartesian coordinate system
215 AudioParam* positionX() const { return m_positionX; }; 215 AudioParam* positionX() const { return m_positionX; };
216 AudioParam* positionY() const { return m_positionY; }; 216 AudioParam* positionY() const { return m_positionY; };
217 AudioParam* positionZ() const { return m_positionZ; }; 217 AudioParam* positionZ() const { return m_positionZ; };
218 218
219 AudioParam* orientationX() const { return m_orientationX; }; 219 AudioParam* orientationX() const { return m_orientationX; };
(...skipping 14 matching lines...) Expand all
234 double rolloffFactor() const; 234 double rolloffFactor() const;
235 void setRolloffFactor(double); 235 void setRolloffFactor(double);
236 double coneInnerAngle() const; 236 double coneInnerAngle() const;
237 void setConeInnerAngle(double); 237 void setConeInnerAngle(double);
238 double coneOuterAngle() const; 238 double coneOuterAngle() const;
239 void setConeOuterAngle(double); 239 void setConeOuterAngle(double);
240 double coneOuterGain() const; 240 double coneOuterGain() const;
241 void setConeOuterGain(double); 241 void setConeOuterGain(double);
242 242
243 private: 243 private:
244 PannerNode(AbstractAudioContext&, float sampleRate); 244 PannerNode(AbstractAudioContext&);
245 245
246 Member<AudioParam> m_positionX; 246 Member<AudioParam> m_positionX;
247 Member<AudioParam> m_positionY; 247 Member<AudioParam> m_positionY;
248 Member<AudioParam> m_positionZ; 248 Member<AudioParam> m_positionZ;
249 249
250 Member<AudioParam> m_orientationX; 250 Member<AudioParam> m_orientationX;
251 Member<AudioParam> m_orientationY; 251 Member<AudioParam> m_orientationY;
252 Member<AudioParam> m_orientationZ; 252 Member<AudioParam> m_orientationZ;
253 }; 253 };
254 254
255 } // namespace blink 255 } // namespace blink
256 256
257 #endif // PannerNode_h 257 #endif // PannerNode_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698