Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/OscillatorNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 AudioFloatArray m_detuneValues; 93 AudioFloatArray m_detuneValues;
94 94
95 // This Persistent doesn't make a reference cycle including the owner 95 // This Persistent doesn't make a reference cycle including the owner
96 // OscillatorNode. 96 // OscillatorNode.
97 Persistent<PeriodicWave> m_periodicWave; 97 Persistent<PeriodicWave> m_periodicWave;
98 }; 98 };
99 99
100 class OscillatorNode final : public AudioScheduledSourceNode { 100 class OscillatorNode final : public AudioScheduledSourceNode {
101 DEFINE_WRAPPERTYPEINFO(); 101 DEFINE_WRAPPERTYPEINFO();
102 public: 102 public:
103 static OscillatorNode* create(AbstractAudioContext&, float sampleRate); 103 static OscillatorNode* create(AbstractAudioContext&, ExceptionState&);
104 DECLARE_VIRTUAL_TRACE(); 104 DECLARE_VIRTUAL_TRACE();
105 105
106 String type() const; 106 String type() const;
107 void setType(const String&, ExceptionState&); 107 void setType(const String&, ExceptionState&);
108 AudioParam* frequency(); 108 AudioParam* frequency();
109 AudioParam* detune(); 109 AudioParam* detune();
110 void setPeriodicWave(PeriodicWave*); 110 void setPeriodicWave(PeriodicWave*);
111 111
112 private: 112 private:
113 OscillatorNode(AbstractAudioContext&, float sampleRate); 113 OscillatorNode(AbstractAudioContext&);
114 OscillatorHandler& oscillatorHandler() const; 114 OscillatorHandler& oscillatorHandler() const;
115 115
116 Member<AudioParam> m_frequency; 116 Member<AudioParam> m_frequency;
117 Member<AudioParam> m_detune; 117 Member<AudioParam> m_detune;
118 }; 118 };
119 119
120 } // namespace blink 120 } // namespace blink
121 121
122 #endif // OscillatorNode_h 122 #endif // OscillatorNode_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698