third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.h - Issue 1952793002: Move the exception logic to the AudioNode creator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 void setChannelCount(unsigned long, ExceptionState&) final;	44 void setChannelCount(unsigned long, ExceptionState&) final;

45 void setChannelCountMode(const String&, ExceptionState&) final;	45 void setChannelCountMode(const String&, ExceptionState&) final;

46	46

47 private:	47 private:

48 ChannelMergerHandler(AudioNode&, float sampleRate, unsigned numberOfInputs);	48 ChannelMergerHandler(AudioNode&, float sampleRate, unsigned numberOfInputs);

49 };	49 };

50	50

51 class ChannelMergerNode final : public AudioNode {	51 class ChannelMergerNode final : public AudioNode {

52 DEFINE_WRAPPERTYPEINFO();	52 DEFINE_WRAPPERTYPEINFO();

53 public:	53 public:

54 static ChannelMergerNode* create(AbstractAudioContext&, float sampleRate, un signed numberOfInputs);	54 static ChannelMergerNode* create(AbstractAudioContext&, ExceptionState&);

	55 static ChannelMergerNode* create(AbstractAudioContext&, unsigned numberOfInp uts, ExceptionState&);

55	56

56 private:	57 private:

57 ChannelMergerNode(AbstractAudioContext&, float sampleRate, unsigned numberOf Inputs);	58 ChannelMergerNode(AbstractAudioContext&, unsigned numberOfInputs);

58 };	59 };

59	60

60 } // namespace blink	61 } // namespace blink

61	62

62 #endif // ChannelMergerNode_h	63 #endif // ChannelMergerNode_h

OLD	NEW