Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 1952763002: Move showLineTreeAndMark() to LayoutBlockFlow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index 85469ef8baeb70befcdbb797f57ebe3e3d300a91..97ca75f7f2f80afcfaba3faa426c4eaadf54569a 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -1659,8 +1659,10 @@ void LayoutObject::showLayoutTreeForThis() const
void LayoutObject::showLineTreeForThis() const
{
- if (containingBlock())
- containingBlock()->showLineTreeAndMark(0, 0, 0, 0, this);
+ if (LayoutBlock* cb = containingBlock()) {
+ if (cb->isLayoutBlockFlow())
wkorman 2016/05/04 20:30:41 Does this change behavior of what we output at all
mstensho (USE GERRIT) 2016/05/04 20:54:25 In theory, yes. If someone wants to display the li
+ toLayoutBlockFlow(cb)->showLineTreeAndMark(0, 0, 0, 0, this);
wkorman 2016/05/04 20:30:41 Use nullptr rather than 0. Is it untoward re: cons
mstensho (USE GERRIT) 2016/05/04 20:54:25 Done.
+ }
}
void LayoutObject::showLayoutObject() const
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698