Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1952753003: Sampling heap profiler: report allocations for nodes with missing script. (Closed)

Created:
4 years, 7 months ago by alph
Modified:
4 years, 7 months ago
Reviewers:
ofrobots, ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Sampling heap profiler: report allocations for nodes with missing script. Committed: https://crrev.com/dae0fecfd22189fda5d072581cd4691e15d71c6b Cr-Commit-Position: refs/heads/master@{#36085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/profiler/sampling-heap-profiler.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952753003/1
4 years, 7 months ago (2016-05-05 02:05:08 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 02:32:19 UTC) #4
alph
4 years, 7 months ago (2016-05-05 14:18:17 UTC) #7
ofrobots
On 2016/05/05 14:18:17, alph wrote: LGTM.
4 years, 7 months ago (2016-05-06 08:40:03 UTC) #8
ulan
lgtm
4 years, 7 months ago (2016-05-06 09:00:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952753003/1
4 years, 7 months ago (2016-05-06 14:21:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 14:49:39 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 14:51:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dae0fecfd22189fda5d072581cd4691e15d71c6b
Cr-Commit-Position: refs/heads/master@{#36085}

Powered by Google App Engine
This is Rietveld 408576698