Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1952753002: Move parts of baseline calculation over to LayoutBlockFlow. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move parts of baseline calculation over to LayoutBlockFlow. LayoutBlock shouldn't deal with line boxes. BUG=302024 Committed: https://crrev.com/061eb2409c683efcd0c2b3f09db0197992ed37c3 Cr-Commit-Position: refs/heads/master@{#391663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -27 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 4 chunks +7 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-04 18:31:42 UTC) #2
leviw_travelin_and_unemployed
lgtm I'm so happy to see you hacking on the old blockflow transition :)
4 years, 7 months ago (2016-05-04 20:51:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952753002/1
4 years, 7 months ago (2016-05-04 20:51:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 22:27:21 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 22:28:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/061eb2409c683efcd0c2b3f09db0197992ed37c3
Cr-Commit-Position: refs/heads/master@{#391663}

Powered by Google App Engine
This is Rietveld 408576698