Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 1952673003: Motown: Rename Ratio and LinearFunction classes (Closed)

Created:
4 years, 7 months ago by dalesat
Modified:
4 years, 7 months ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Motown: Rename Ratio and LinearFunction classes The new Ratio and LinearFunction classes are intended to help dealing with timeline transformations. The names suggest that they implement the mathematical concepts in a general way - this is not the case. Furthermore, the generic names of their methods force a developer to map between concepts, diluting the helpfulness of these helper classes. This CL is strictly a rename...no functional changes were made. The name mapping is: from: to: Ratio TimelineRate numerator subject_delta denominator reference_delta LinearFunction TimelineFunction domain_basis reference_time range_basis subject_time slope rate domain_delta reference_delta range_delta subject_delta R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7da601026e514860a4f8c47e21a8bcb15727231b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1031 lines, -1128 lines) Patch
M mojo/dart/packages/mojo_services/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/dart/packages/mojo_services/lib/mojo/timelines.mojom.dart View 17 chunks +202 lines, -161 lines 0 comments Download
M mojo/services/media/common/cpp/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
D mojo/services/media/common/cpp/linear_function.h View 1 chunk +0 lines, -123 lines 0 comments Download
D mojo/services/media/common/cpp/linear_function.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/services/media/common/cpp/ratio.h View 1 chunk +0 lines, -118 lines 0 comments Download
D mojo/services/media/common/cpp/ratio.cc View 1 chunk +0 lines, -228 lines 0 comments Download
A mojo/services/media/common/cpp/timeline_function.h View 1 chunk +133 lines, -0 lines 0 comments Download
A mojo/services/media/common/cpp/timeline_function.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A mojo/services/media/common/cpp/timeline_rate.h View 1 chunk +128 lines, -0 lines 0 comments Download
A + mojo/services/media/common/cpp/timeline_rate.cc View 5 chunks +59 lines, -54 lines 0 comments Download
A mojo/services/media/common/interfaces/timelines.mojom View 1 chunk +57 lines, -0 lines 0 comments Download
M services/media/common/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D services/media/common/test/linear_function_test.cc View 1 chunk +0 lines, -226 lines 0 comments Download
D services/media/common/test/ratio_test.cc View 1 chunk +0 lines, -181 lines 0 comments Download
A services/media/common/test/timeline_function_test.cc View 1 chunk +227 lines, -0 lines 0 comments Download
A services/media/common/test/timeline_rate_test.cc View 1 chunk +186 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dalesat
Please take a look. Thanks!
4 years, 7 months ago (2016-05-04 21:28:05 UTC) #3
kulakowski
lgtm
4 years, 7 months ago (2016-05-05 21:32:03 UTC) #4
dalesat
4 years, 7 months ago (2016-05-05 22:47:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7da601026e514860a4f8c47e21a8bcb15727231b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698