Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: pkg/analyzer/lib/src/summary/summarize_const_expr.dart

Issue 1952663006: Support for NamedExpression(s) as constructor initializer arguments. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/summarize_const_expr.dart
diff --git a/pkg/analyzer/lib/src/summary/summarize_const_expr.dart b/pkg/analyzer/lib/src/summary/summarize_const_expr.dart
index 17a0b511e4706479aa5fc89fa322b99f3887e4d8..f76fed2ec7af5546ff1d28960e9054a36e89b07b 100644
--- a/pkg/analyzer/lib/src/summary/summarize_const_expr.dart
+++ b/pkg/analyzer/lib/src/summary/summarize_const_expr.dart
@@ -45,11 +45,16 @@ UnlinkedConstructorInitializer serializeConstructorInitializer(
*/
abstract class AbstractConstExprSerializer {
/**
- * See [UnlinkedConstBuilder.isInvalid].
+ * See [UnlinkedConstBuilder.isValidConst].
*/
bool isValidConst = true;
/**
+ * See [UnlinkedConstBuilder.nmae].
+ */
+ String name = null;
+
+ /**
* See [UnlinkedConstBuilder.operations].
*/
final List<UnlinkedConstOperation> operations = <UnlinkedConstOperation>[];
@@ -91,6 +96,11 @@ abstract class AbstractConstExprSerializer {
*/
void serialize(Expression expr) {
try {
+ if (expr is NamedExpression) {
+ NamedExpression namedExpression = expr;
+ name = namedExpression.name.label.name;
+ expr = namedExpression.expression;
+ }
_serialize(expr);
} on StateError {
isValidConst = false;
@@ -152,6 +162,7 @@ abstract class AbstractConstExprSerializer {
UnlinkedConstBuilder toBuilder() {
return new UnlinkedConstBuilder(
isValidConst: isValidConst,
+ name: name,
operations: operations,
assignmentOperators: assignmentOperators,
ints: ints,

Powered by Google App Engine
This is Rietveld 408576698