Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1952633002: [full-codegen] Introduce NestedStatement subclass for class literals. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[full-codegen] Introduce NestedStatement subclass for class literals. This fixes a bug where returning from a class literal inside a try-finally didn't restore the context properly when entering the finally clause. BUG=v8:4965 LOG=n Committed: https://crrev.com/06c5127f5b913ece43b702c18a91f56696acb111 Cr-Commit-Position: refs/heads/master@{#36021}

Patch Set 1 #

Patch Set 2 : More tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -1 line) Patch
M src/full-codegen/full-codegen.h View 1 chunk +17 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/es6/classes.js View 1 2 chunks +53 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952633002/20001
4 years, 7 months ago (2016-05-04 12:02:20 UTC) #3
neis
ptal
4 years, 7 months ago (2016-05-04 12:08:37 UTC) #5
Jarin
lgtm. Thanks!
4 years, 7 months ago (2016-05-04 12:12:26 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 12:26:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952633002/20001
4 years, 7 months ago (2016-05-04 12:39:58 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 12:41:58 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 12:42:11 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/06c5127f5b913ece43b702c18a91f56696acb111
Cr-Commit-Position: refs/heads/master@{#36021}

Powered by Google App Engine
This is Rietveld 408576698