Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1952623002: [compiler] Remove is_native and is_eval accessors. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove is_native and is_eval accessors. This removes some low-level accessors from the CompilationInfo which only delegate to the ParseInfo. Instead we add a helper that computes the flags passed to DeclareGlobals for all backends. R=titzer@chromium.org Committed: https://crrev.com/068791e2ca47459820e6cd22fd34dc9da72bbe7c Cr-Commit-Position: refs/heads/master@{#36030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -30 lines) Patch
M src/compiler.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/compiler.cc View 4 chunks +17 lines, -12 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-04 11:26:48 UTC) #1
titzer
On 2016/05/04 11:26:48, Michael Starzinger wrote: lgtm
4 years, 7 months ago (2016-05-04 11:31:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952623002/1
4 years, 7 months ago (2016-05-04 14:06:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14662)
4 years, 7 months ago (2016-05-04 14:10:13 UTC) #6
Michael Starzinger
+Jaro: Need Crankshaft stamp.
4 years, 7 months ago (2016-05-04 14:52:03 UTC) #8
Jakob Kummerow
lgtm
4 years, 7 months ago (2016-05-04 15:44:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952623002/1
4 years, 7 months ago (2016-05-04 15:55:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 15:57:39 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 16:00:12 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/068791e2ca47459820e6cd22fd34dc9da72bbe7c
Cr-Commit-Position: refs/heads/master@{#36030}

Powered by Google App Engine
This is Rietveld 408576698