Move LayoutDeprecatedFlexibleBox-specific line handling.

Move LayoutDeprecatedFlexibleBox-specific line handling.

This is sort-of exotic functionality, in that it checks if the blocks have
visibility:visible and auto height, so it fits better together with the
LayoutDeprecatedFlexibleBox implementation. Nobody else needs this.

The pagination code also needs to count lines, though, so I kept lineCount(),
but moved it from LayoutBlock to LayoutBlockFlow, and threw away the parts that
weren't needed (visibility check, recursing into child block flows, among other
things).

On the LayoutDeprecatedFlexibleBox, there are some changes. The functions now
operate on LayoutBlockFlow instead of LayoutBlock, since it's dealing with
lines. As a result, we need to replace some former isLayoutBlock() checks with
isLayoutBlockFlow(). A similar change landed in WebKit years ago [1], so it
should be safe.

[1] https://bugs.webkit.org/show_bug.cgi?id=122969

BUG=302024
Committed: https://crrev.com/f42912bb9538bbd7c9817c4a210dd202b69be29f
Cr-Commit-Position: refs/heads/master@{#391492}

[mstensho (USE GERRIT), 2016-05-04 12:03:42]

mstensho@opera.com changed reviewers:
+ eae@chromium.org, leviw@chromium.org, szager@chromium.org,
wkorman@chromium.org

[eae, 2016-05-04 12:07:27]

LGTM, deprecate all the things.

https://codereview.chromium.org/1952613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):

https://codereview.chromium.org/1952613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:1946: for
(RootInlineBox* box = firstRootBox(); box; box = box->nextRootBox()) {
const RootInlineBox*?

[mstensho (USE GERRIT), 2016-05-04 12:14:00]

https://codereview.chromium.org/1952613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):

https://codereview.chromium.org/1952613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:1946: for
(RootInlineBox* box = firstRootBox(); box; box = box->nextRootBox()) {
On 2016/05/04 12:07:27, eae wrote:
> const RootInlineBox*?

Done.

[mstensho (USE GERRIT), 2016-05-04 12:14:17]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-05-04 12:14:17]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1952613002/#ps20001
(title: "Const all the things!")

[commit-bot: I haz the power, 2016-05-04 12:14:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952613002/20001

[commit-bot: I haz the power, 2016-05-04 13:29:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-04 13:30:50]

Description was changed from

==========
Move LayoutDeprecatedFlexibleBox-specific line handling.

This is sort-of exotic functionality, in that it checks if the blocks have
visibility:visible and auto height, so it fits better together with the
LayoutDeprecatedFlexibleBox implementation. Nobody else needs this.

The pagination code also needs to count lines, though, so I kept lineCount(),
but moved it from LayoutBlock to LayoutBlockFlow, and threw away the parts that
weren't needed (visibility check, recursing into child block flows, among other
things).

On the LayoutDeprecatedFlexibleBox, there are some changes. The functions now
operate on LayoutBlockFlow instead of LayoutBlock, since it's dealing with
lines. As a result, we need to replace some former isLayoutBlock() checks with
isLayoutBlockFlow(). A similar change landed in WebKit years ago [1], so it
should be safe.

[1] https://bugs.webkit.org/show_bug.cgi?id=122969

BUG=302024
==========

to

==========
Move LayoutDeprecatedFlexibleBox-specific line handling.

This is sort-of exotic functionality, in that it checks if the blocks have
visibility:visible and auto height, so it fits better together with the
LayoutDeprecatedFlexibleBox implementation. Nobody else needs this.

The pagination code also needs to count lines, though, so I kept lineCount(),
but moved it from LayoutBlock to LayoutBlockFlow, and threw away the parts that
weren't needed (visibility check, recursing into child block flows, among other
things).

On the LayoutDeprecatedFlexibleBox, there are some changes. The functions now
operate on LayoutBlockFlow instead of LayoutBlock, since it's dealing with
lines. As a result, we need to replace some former isLayoutBlock() checks with
isLayoutBlockFlow(). A similar change landed in WebKit years ago [1], so it
should be safe.

[1] https://bugs.webkit.org/show_bug.cgi?id=122969

BUG=302024

Committed: https://crrev.com/f42912bb9538bbd7c9817c4a210dd202b69be29f
Cr-Commit-Position: refs/heads/master@{#391492}
==========

[commit-bot: I haz the power, 2016-05-04 13:30:51]

Patchset 2 (id:??) landed as
https://crrev.com/f42912bb9538bbd7c9817c4a210dd202b69be29f
Cr-Commit-Position: refs/heads/master@{#391492}