Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3060)

Unified Diff: base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java

Issue 1952573002: Add DisableIf annotation to EME test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/android/javatests/src/org/chromium/base/test/util/DisableIf.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java
diff --git a/base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java b/base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java
index 9fa7d82ff85775b8ed7b5a705f1ab9aff5a37155..38eb16ada8347d3f83d324f6f1dfc95ce1563e73 100644
--- a/base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java
+++ b/base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java
@@ -56,6 +56,11 @@ public class DisableIfSkipCheck extends SkipCheck {
return v.hardware_is().isEmpty() || Build.HARDWARE.equals(v.hardware_is());
}
+ private boolean product(DisableIf.Build v) {
+ return v.product_name_includes().isEmpty()
+ || Build.PRODUCT.contains(v.product_name_includes());
+ }
+
private boolean sdk(DisableIf.Build v) {
return Build.VERSION.SDK_INT > v.sdk_is_greater_than()
&& Build.VERSION.SDK_INT < v.sdk_is_less_than();
« no previous file with comments | « base/test/android/javatests/src/org/chromium/base/test/util/DisableIf.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698