Rename and refactor ScrollOffsetAnimations to ScrollOffsetAnimationsImpl

Rename and refactor ScrollOffsetAnimations to ScrollOffsetAnimationsImpl

Pre-req CL to enable communication between MT and impl-only animations. This
is described in http://bit.ly/1Y6RA6y.

Note that this CL has no behavioral change.

BUG=594456
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/1b8eeda89c1ddb96201d98c9446afd5da2d68c18
Cr-Commit-Position: refs/heads/master@{#391530}

[ymalik, 2016-05-04 01:46:43]

Description was changed from

==========
Rename and refactor ScrollOffsetAnimations to ScrollOffsetAnimationsHostImpl

Pre-req CL to enable communication between MT and impl-only animations. This
is described in http://bit.ly/1Y6RA6y.

Note that this CL has no behavioral change.

BUG=594456
==========

to

==========
Rename and refactor ScrollOffsetAnimations to ScrollOffsetAnimationsHostImpl

Pre-req CL to enable communication between MT and impl-only animations. This
is described in http://bit.ly/1Y6RA6y.

Note that this CL has no behavioral change.

BUG=594456
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ymalik, 2016-05-04 01:58:41]

ymalik@chromium.org changed reviewers:
+ ajuma@chromium.org, loyso@chromium.org

[loyso (OOO), 2016-05-04 06:36:50]

ajuma@, may we leave it as ScrollOffsetAnimations and
ScrollOffsetAnimationsImpl? Would it be too generic?

[ajuma, 2016-05-04 13:42:47]

On 2016/05/04 06:36:50, loyso wrote:
> ajuma@, may we leave it as ScrollOffsetAnimations and
> ScrollOffsetAnimationsImpl? Would it be too generic?

That would work too (with class comments explaining what these are for).
ymalik@, wdyt?

[ymalik, 2016-05-04 14:47:46]

On 2016/05/04 13:42:47, ajuma wrote:
> On 2016/05/04 06:36:50, loyso wrote:
> > ajuma@, may we leave it as ScrollOffsetAnimations and
> > ScrollOffsetAnimationsImpl? Would it be too generic?
> 
> That would work too (with class comments explaining what these are for).
> ymalik@, wdyt?

Yeah that sgtm. Renamed and added comment. PTAL :)

[ajuma, 2016-05-04 15:01:22]

Thanks, lgtm

[ymalik, 2016-05-04 15:06:07]

The CQ bit was checked by ymalik@chromium.org

[commit-bot: I haz the power, 2016-05-04 15:06:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952563002/40001

[ymalik, 2016-05-04 15:07:36]

On 2016/05/04 15:01:22, ajuma wrote:
> Thanks, lgtm

@loyso, I will submit this to unblock follow-up changes. 
Feel free to add other comments here and I can address them in the coming CLs.

[ymalik, 2016-05-04 15:09:09]

Description was changed from

==========
Rename and refactor ScrollOffsetAnimations to ScrollOffsetAnimationsHostImpl

Pre-req CL to enable communication between MT and impl-only animations. This
is described in http://bit.ly/1Y6RA6y.

Note that this CL has no behavioral change.

BUG=594456
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Rename and refactor ScrollOffsetAnimations to ScrollOffsetAnimationsImpl

Pre-req CL to enable communication between MT and impl-only animations. This
is described in http://bit.ly/1Y6RA6y.

Note that this CL has no behavioral change.

BUG=594456
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-04 16:18:27]

Description was changed from

==========
Rename and refactor ScrollOffsetAnimations to ScrollOffsetAnimationsImpl

Pre-req CL to enable communication between MT and impl-only animations. This
is described in http://bit.ly/1Y6RA6y.

Note that this CL has no behavioral change.

BUG=594456
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Rename and refactor ScrollOffsetAnimations to ScrollOffsetAnimationsImpl

Pre-req CL to enable communication between MT and impl-only animations. This
is described in http://bit.ly/1Y6RA6y.

Note that this CL has no behavioral change.

BUG=594456
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-04 16:18:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-04 16:20:01]

Description was changed from

==========
Rename and refactor ScrollOffsetAnimations to ScrollOffsetAnimationsImpl

Pre-req CL to enable communication between MT and impl-only animations. This
is described in http://bit.ly/1Y6RA6y.

Note that this CL has no behavioral change.

BUG=594456
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Rename and refactor ScrollOffsetAnimations to ScrollOffsetAnimationsImpl

Pre-req CL to enable communication between MT and impl-only animations. This
is described in http://bit.ly/1Y6RA6y.

Note that this CL has no behavioral change.

BUG=594456
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/1b8eeda89c1ddb96201d98c9446afd5da2d68c18
Cr-Commit-Position: refs/heads/master@{#391530}
==========

[commit-bot: I haz the power, 2016-05-04 16:20:02]

Patchset 3 (id:??) landed as
https://crrev.com/1b8eeda89c1ddb96201d98c9446afd5da2d68c18
Cr-Commit-Position: refs/heads/master@{#391530}

[loyso (OOO), 2016-05-04 23:47:21]

LGTM with a nit.

https://codereview.chromium.org/1952563002/diff/40001/cc/animation/animation_...
File cc/animation/animation_host.h (right):

https://codereview.chromium.org/1952563002/diff/40001/cc/animation/animation_...
cc/animation/animation_host.h:16: #include
"cc/animation/scroll_offset_animations_impl.h"
Nit: You could use forward declaration here.