[DevTools] Auto completion for proxy uses proxy target object

third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 508 matching lines @@
          * @this {WebInspector.ExecutionContext}
          */
         function evaluated(result, wasThrown)
         {
             if (!result || wasThrown) {
                 completionsReadyCallback([]);
                 return;
             }
 
             /**
+             * @param {?Array<!WebInspector.RemoteObjectProperty>} properties
+             * @param {?Array.<!WebInspector.RemoteObjectProperty>} internalProperties
+             * @this {WebInspector.ExecutionContext}
+             */
+            function completionsForProxyTarget(properties, internalProperties)
+            {
+                if (internalProperties) {

[lushnikov, 2016/05/04 19:27:21]

lets use as much fast returns as possible! the less nesting the better!

[pfeldman, 2016/05/04 22:45:07]

+1

[kozy, 2016/05/05 00:51:08]

Done.

+                    for (var property of internalProperties) {
+                        if (property.name === "[[Target]]") {
+                            var target = property.value;
+                            if (target.subtype !== "proxy")
+                                target.callFunctionJSON(getCompletions, [WebInspector.RemoteObject.toCallArgument(target.subtype)], receivedPropertyNames.bind(this));
+                            else
+                                target.getOwnProperties(completionsForProxyTarget.bind(this));
+                            return;
+                        }
+                    }
+                }
+                completionsReadyCallback([]);
+            }
+
+            /**
              * @param {string=} type
              * @suppressReceiverCheck
-             * @this {WebInspector.ExecutionContext}
+             * @this {*}
              */
             function getCompletions(type)
             {
                 var object;
                 if (type === "string")
                     object = new String("");
                 else if (type === "number")
                     object = new Number(0);
                 else if (type === "boolean")
                     object = new Boolean(false);
                 else
                     object = this;
 
                 var resultSet = {};
                 try {
                     for (var o = object; o; o = o.__proto__) {
                         if (type === "array" && o === object && ArrayBuffer.isView(o) && o.length > 9999)
                             continue;
-                        var names = Object.getOwnPropertyNames(o);
+                        var names = Object.getOwnPropertyNames(/** @type{!Object} */(o));
                         var isArray = Array.isArray(o);
                         for (var i = 0; i < names.length; ++i) {
                             // Skip array elements indexes.
                             if (isArray && /^[0-9]/.test(names[i]))
                                 continue;
                             resultSet[names[i]] = true;
                         }
                     }
                 } catch (e) {
                 }
                 return resultSet;
             }
 
-            if (result.type === "object" || result.type === "function")
+            if (result.type === "object" && result.subtype === "proxy")

[lushnikov, 2016/05/04 19:27:21]

result = extractTarget(result).then(onTarget);


fun extractTarget(obj) {
    if (result.type !== "object" || result.subtype !== "proxy")
       return result;
    ... find target recursively ...
}

[kozy, 2016/05/05 00:51:08]

Done.

+                result.getOwnProperties(completionsForProxyTarget.bind(this));
+            else if (result.type === "object" || result.type === "function")
                 result.callFunctionJSON(getCompletions, [WebInspector.RemoteObject.toCallArgument(result.subtype)], receivedPropertyNames.bind(this));
             else if (result.type === "string" || result.type === "number" || result.type === "boolean")
                 this.evaluate("(" + getCompletions + ")(\"" + result.type + "\")", "completion", false, true, true, false, false, receivedPropertyNamesFromEval.bind(this));
         }
 
         /**
          * @param {?WebInspector.RemoteObject} notRelevant
          * @param {boolean} wasThrown
          * @param {?RuntimeAgent.RemoteObject=} result
          * @this {WebInspector.ExecutionContext}
@@ skipping 238 matching lines @@
     /**
      * @param {string} listenerType
      */
     setListenerType: function(listenerType)
     {
         this._listenerType = listenerType;
     },
 
     __proto__: WebInspector.SDKObject.prototype
 }