Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: base/posix/global_descriptors.h

Issue 1952513003: Fix Android multi-process tests on M. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/test/multiprocess_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/posix/global_descriptors.h
diff --git a/base/posix/global_descriptors.h b/base/posix/global_descriptors.h
index c774634f59bf9c45bd9acce2a7762de19b3b257b..1761e2518f82f36f9fd5832585d998a9c41a2531 100644
--- a/base/posix/global_descriptors.h
+++ b/base/posix/global_descriptors.h
@@ -55,7 +55,9 @@ class BASE_EXPORT GlobalDescriptors {
#if !defined(OS_ANDROID)
static const int kBaseDescriptor = 3; // 0, 1, 2 are already taken.
#else
- static const int kBaseDescriptor = 4; // 3 used by __android_log_write().
+ // 3 used by __android_log_write().
+ // 4 used by... something important on Android M.
Mark Mentovai 2016/05/04 12:07:12 Wish we had more confidence in what this was. What
Anand Mistry (off Chromium) 2016/05/04 21:48:42 The problem I came across is that closing or dup'i
+ static const int kBaseDescriptor = 5;
#endif
// Return the singleton instance of GlobalDescriptors.
« no previous file with comments | « no previous file | base/test/multiprocess_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698