Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1952503003: [Devtools] Fixed XSL sheets not showing in network tab (Closed)

Created:
4 years, 7 months ago by allada
Modified:
4 years, 7 months ago
Reviewers:
caseq, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed XSL sheets not showing in network tab Fixes bug where XSL stylesheets were not showing in the network tab due to wrong cache type trying to be sent to frontend. BUG=603806 R=lushnikov Committed: https://crrev.com/2a4d133ee194fcc70e377f387c1200c32619743c Cr-Commit-Position: refs/heads/master@{#391838}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Messages

Total messages: 15 (6 generated)
allada
PTL
4 years, 7 months ago (2016-05-04 22:33:38 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/1952503003/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xsl-content.html File third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xsl-content.html (right): https://codereview.chromium.org/1952503003/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xsl-content.html#newcode6 third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xsl-content.html:6: //window.debugTest = true; let's remove this https://codereview.chromium.org/1952503003/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xsl-content.html#newcode29 third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xsl-content.html:29: ...
4 years, 7 months ago (2016-05-04 23:03:36 UTC) #3
allada
Done. https://codereview.chromium.org/1952503003/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xsl-content.html File third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xsl-content.html (right): https://codereview.chromium.org/1952503003/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xsl-content.html#newcode6 third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xsl-content.html:6: //window.debugTest = true; On 2016/05/04 23:03:36, lushnikov wrote: ...
4 years, 7 months ago (2016-05-04 23:46:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952503003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952503003/40001
4 years, 7 months ago (2016-05-04 23:47:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/177913)
4 years, 7 months ago (2016-05-04 23:55:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952503003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952503003/40001
4 years, 7 months ago (2016-05-05 16:05:21 UTC) #11
caseq
lgtm
4 years, 7 months ago (2016-05-05 16:09:37 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-05 17:54:52 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 17:56:40 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2a4d133ee194fcc70e377f387c1200c32619743c
Cr-Commit-Position: refs/heads/master@{#391838}

Powered by Google App Engine
This is Rietveld 408576698