Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1952493002: MD Settings: Proof of concept, highlighting search matches across Shadow DOM boundaries.

Created:
4 years, 7 months ago by dpapad
Modified:
4 years, 7 months ago
Reviewers:
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Proof of concept, highlighting search matches across Shadow DOM boundaries. Porting the old Options highlighting mechanism to work across Shadow DOM. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Patch Set 1 : Highlighting works! #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -6 lines) Patch
A chrome/browser/resources/settings/search_settings.js View 1 chunk +139 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (13 generated)
dpapad
Description was changed from ========== MD Settings: Proof of concept, highlighting search matches across Shadow ...
4 years, 7 months ago (2016-05-03 22:42:28 UTC) #1
dpapad
Description was changed from ========== MD Settings: Proof of concept, highlighting search matches across Shadow ...
4 years, 7 months ago (2016-05-03 22:52:12 UTC) #2
dpapad
Patchset #4 (id:60001) has been deleted
4 years, 7 months ago (2016-05-04 01:17:26 UTC) #3
dpapad
Patchset #3 (id:40001) has been deleted
4 years, 7 months ago (2016-05-04 01:17:31 UTC) #4
dpapad
Patchset #2 (id:20001) has been deleted
4 years, 7 months ago (2016-05-04 01:17:36 UTC) #5
dpapad
Patchset #3 (id:100001) has been deleted
4 years, 7 months ago (2016-05-04 01:25:35 UTC) #6
dpapad
Patchset #2 (id:80001) has been deleted
4 years, 7 months ago (2016-05-04 01:25:39 UTC) #7
dpapad
Patchset #1 (id:1) has been deleted
4 years, 7 months ago (2016-05-04 01:25:44 UTC) #8
dpapad
Patchset #4 (id:180001) has been deleted
4 years, 7 months ago (2016-05-04 21:37:40 UTC) #9
dpapad
Patchset #3 (id:160001) has been deleted
4 years, 7 months ago (2016-05-04 21:37:46 UTC) #10
dpapad
Patchset #2 (id:140001) has been deleted
4 years, 7 months ago (2016-05-04 21:37:50 UTC) #11
dpapad
Patchset #1 (id:120001) has been deleted
4 years, 7 months ago (2016-05-04 21:37:55 UTC) #12
dpapad
4 years, 7 months ago (2016-05-04 22:00:12 UTC) #13 
Patchset #1 (id:200001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698