third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-takePhoto.html - Issue 1952463002: Media Stream Image Capture (4): wire takePhoto and implement in FakeVCDevice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-takePhoto.html

Issue 1952463002: Media Stream Image Capture (4): wire takePhoto and implement in FakeVCDevice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: miu@s comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/capture/video/fake_video_capture_device_unittest.cc ('K') | « media/capture/video/video_capture_device.cc ('k') | third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-takePhoto.html

diff --git a/third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-takePhoto.html b/third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-takePhoto.html

index b8d40007f7865d030c46fd188bb67c570729a533..a71a0f27c918487f19eb9f83e33531ce6cf920b4 100644

--- a/third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-takePhoto.html

+++ b/third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-takePhoto.html

@@ -20,12 +20,13 @@ var test = async_test(function() {

capturer.takePhoto()

.then(blob => {

- assert_true(blob.type.length > 0);

- assert_true(blob.size > 0);

- this.done();

+ assert_unreached('takePhoto() should not have been resolved');

})

.catch(error => {

- assert_unreached('Error during takePhoto(): '+ error);

+ // LayoutTests do not have a real or a fake camera whatsoever, so content

+ // will not find a matching device for the Track's source id, and the

+ // promise will be rejected.

+ this.done();

});

}, 'exercises the ImageCapture API takePhoto().');